Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate @ConfigurationProperties#ignoreUnknownFields #12601

Open
snicoll opened this Issue Mar 22, 2018 · 2 comments

Comments

Projects
None yet
4 participants
@snicoll
Copy link
Member

snicoll commented Mar 22, 2018

ignoreUnknownFields allows to spot cases where a property on the target namespace was left unbound. It is an interesting feature with a serious limitation (#3445) that means we hardly use it in practice.

We should consider deprecating it in the next feature release.

@snicoll snicoll added the type: task label Mar 22, 2018

@snicoll snicoll added this to the Backlog milestone Mar 22, 2018

@wilkinsona wilkinsona changed the title Consider deprecating @ConfigurationProperties#ignoreUnknownFields Deprecate @ConfigurationProperties#ignoreUnknownFields Jun 1, 2018

@snicoll snicoll assigned snicoll and unassigned snicoll Jun 1, 2018

@snicoll

This comment has been minimized.

Copy link
Member Author

snicoll commented Jun 5, 2018

Trying to come up with a deprecated message for this, I think it would be more fair to deprecate it when we tackle #10030

@philwebb philwebb removed this from the Backlog milestone Jun 6, 2018

@snicoll snicoll added this to the Icebox milestone Jun 6, 2018

@thombergs

This comment has been minimized.

Copy link
Contributor

thombergs commented Mar 17, 2019

I noticed that ignoreUnknownFields=false does not work when ignoreInvalidFields is set to true.

It seems that as soon as invalid fields are ignored, unknown fields are also ignored, no matter what the value of ignoreUnknownFields, which is not what I would expect.

Since ignoreUnknownFields will be deprecated, I didn't want to raise a new issue, but wanted to document it here in case anyone else stumbles upon this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.