New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please update spring-boot-dependencies' HikariCP version #12759

Closed
matsumana opened this Issue Apr 4, 2018 · 6 comments

Comments

Projects
None yet
6 participants
@matsumana

matsumana commented Apr 4, 2018

Spring Boot 2.0.0 depends on HikariCP 2.7.8 but there is a issue in HikariCP so we can't collect metrics for now.
The issue has been fixed in HikariCP 3.0.0
Please update spring-boot-dependencies' HikariCP version.

ref:

@wilkinsona

This comment has been minimized.

Member

wilkinsona commented Apr 4, 2018

Thanks, but we can't upgrade to a new major version of Hikari in a maintenance version of Spring Boot. You can override the hikaricp.version property if you want to use a version other than the one provided by Boot. Hopefully there will be a Hikari 2.7.9 release that incorporates the fix. If there is, we will upgrade to it in due course.

/cc @brettwooldridge

@rajadilipkolli

This comment has been minimized.

Contributor

rajadilipkolli commented Apr 4, 2018

@wilkinsona Will this be upgraded to 3.0.0 when Spring boot 2.1 is released?

@philwebb

This comment has been minimized.

Member

philwebb commented Apr 4, 2018

@rajadileepkolli we'll upgrade to whatever the latest version of Hikari is at the time of the 2.1 release.

@brettwooldridge

This comment has been minimized.

Contributor

brettwooldridge commented Apr 5, 2018

@wilkinsona @philwebb @rajadilipkolli @matsumana I have published a v2.7.9 artifact with only the Micrometer v1.0.0 changes that were included in v3.0.0 merged.

@matsumana

This comment has been minimized.

matsumana commented Apr 5, 2018

Thank you for the releasing.
I confirmed that metrics can be collected with Spring Boot 2.0.0 + HikariCP 2.7.9

@philwebb

This comment has been minimized.

Member

philwebb commented Apr 5, 2018

Oh sweet. Thanks @brettwooldridge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment