Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to reactor-netty 0.8.0 and Spring Framework 5.1 #13321

Closed
bclozel opened this issue May 31, 2018 · 1 comment

Comments

Projects
None yet
1 participant
@bclozel
Copy link
Member

commented May 31, 2018

Spring Framework 5.1 is now using reactor-netty 0.8, which comes with breaking changes in its APIs, but also a change in the package names and artifact coordinates.

This migration has been applied to Spring Framework with spring-projects/spring-framework#1845.

@bclozel bclozel added this to the 2.1.0.M1 milestone May 31, 2018

@bclozel bclozel self-assigned this May 31, 2018

@bclozel

This comment has been minimized.

Copy link
Member Author

commented Jun 1, 2018

This is in progress:

  • one issue with the TLS client certificate support in HttpClient (the client not sending the certificate to the server); see reactor/reactor-netty#369
  • because HttpServer.Builder no longer exists, we'll have to break the NettyServerCustomizer API. HttpServer is now built with a stateless builder API
  • the new reactor-netty API is missing a way to get the port information, I've opened reactor/reactor-netty#368 and temporarily ignored NettyReactiveWebServerFactoryTests.exceptionIsThrownWhenPortIsAlreadyInUse
  • the reactor-bom needs to publish the new artifact, the new groupId is io.projectreactor.netty instead of io.projectreactor.ipc; see reactor/reactor#646
  • SSL configuration issues with boringssl reactor/reactor-netty#384

bclozel added a commit that referenced this issue Jun 4, 2018

Upgrade to Spring Framework 5.1
As of Spring Framework 5.1, we're depending on the Reactor Californium
release train.
Reactor Netty is now at version 0.8 and changed its artifact
coordinates, package names and broke several APIs. Spring Framework is
now up-to-date with those changes and this commit does the same for
Spring Boot.

Note that in that process, the `NettyServerCustomizer` has been changed
since the former `HttpServerOptions.Builder` API is now gone from
Reactor Netty, and we're now relying on immutable server instances
instead of a stateful builder pattern.

See gh-13321

@bclozel bclozel changed the title Upgrade to reactor-netty 0.8.0 Upgrade to reactor-netty 0.8.0 and Spring Framework 5.1 Jun 4, 2018

bclozel added a commit that referenced this issue Jun 4, 2018

@bclozel bclozel closed this in 57dbea0 Jul 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.