Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DevTools incorrectly logs a change in condition evaluation when starting an application with multiple contexts #15766

Closed
xak2000 opened this issue Jan 23, 2019 · 1 comment

Comments

Projects
None yet
3 participants
@xak2000
Copy link
Contributor

commented Jan 23, 2019

I tried to run multi-context spring-boot application as Andy Wilkinson described in his answer and it works, but some strange thing happen: ConditionEvaluationDeltaLoggingListener prints report between first and second child context start.

It prints:

2019-01-22 16:40:46.477  INFO 3268 --- [  restartedMain] .ConditionEvaluationDeltaLoggingListener : Condition evaluation delta:


==========================
CONDITION EVALUATION DELTA
==========================


Positive matches:
-----------------

   DispatcherServletAutoConfiguration matched:
      - @ConditionalOnClass found required class 'org.springframework.web.servlet.DispatcherServlet' (OnClassCondition)
      - found 'session' scope (OnWebApplicationCondition)

..and many more rows.

Andy thinks that it can be a bug in dev-tools, so I opened report here.
MCVE: gh-15766.zip
You can run it with mvnw spring-boot:run.

Spring boot: 2.1.2.RELEASE

@wilkinsona

This comment has been minimized.

Copy link
Member

commented Jan 24, 2019

Thanks for opening an issue. We need to update ConditionEvaluationDeltaLoggingListener to be aware of the context for which the previous report was generated, otherwise it will report a delta between two different contexts rather than two different iterations of the same context.

@wilkinsona wilkinsona self-assigned this Jan 24, 2019

@wilkinsona wilkinsona added this to the 2.1.x milestone Jan 24, 2019

@wilkinsona wilkinsona modified the milestones: 2.1.x, 2.1.3 Feb 14, 2019

@wilkinsona wilkinsona changed the title dev-tools ConditionEvaluationDeltaLoggingListener on multi-child context application DevTools incorrectly logs a change in condition evaluation when starting an application with multiple contexts Feb 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.