New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RabbitMQ auto-configuration support when camel-rabbit is used instead of rabbit-amqp #17534
Comments
@rfelgent I've edited your comment to improve the formatting. You might want to check out this Mastering Markdown guide for future reference. |
As things stand, we don't create a |
Hello people, thx for you replies. @snicoll , thx for your edits and sorry, that my formatting was not properly! What exactly do you mean by saying:
Imho, you do create (or reference) the Maybe it is an idea to move the functionality of "AbstractConnectionFactory" class to spring-boot-autoconfigure and the implementation supports only the "raw" rabbit connection factory. |
You missed the word "bean" off the end that is important. While we do create a
|
Hi @wilkinsona ,
Sorry, I did not express myself very good. I know about the circular dependency. I was talking about the functionality in general (facade, abstraction over connectionfactory). Anyway, the |
Hello people,
I am using "camel-rabbit" instead of "rabbit-amqp" for different reasons.
By using "camel-rabbit" I loose all the autoconfiguration of
To make this work, I craeted my own implementations for the features in question:
In my experience, either using "camel-rabbit" or "spring-amqp" both rely on the "ConnectionFactory" from the "rabbit-client".
In my project, the camel-rabbit components are configured to reuse the "ConnectionFactory" available in the Spring Context.
It would be great to have the default implementation of "RabbitMetricsAutoConfiguration" and "RabbitHealthIndicator" only dependend on "ConnectionFactory".
Best regards
The text was updated successfully, but these errors were encountered: