Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binder can throw NPE if BindHandler.onStart return null #18129

Closed
philwebb opened this issue Sep 4, 2019 · 1 comment

Comments

@philwebb
Copy link
Member

commented Sep 4, 2019

The Binder currently has this code which replaced the target:

target = handler.onStart(name, target, context);

Since the result can be null, the subsequent call to handleBindResult could throw an NPE

@philwebb philwebb added this to the 2.1.x milestone Sep 4, 2019
@philwebb philwebb added the type: bug label Sep 4, 2019
@philwebb philwebb modified the milestones: 2.1.x, 2.2.x Sep 4, 2019
@philwebb

This comment has been minimized.

Copy link
Member Author

commented Sep 4, 2019

Looks like a 2.2.x issue only, in 2.1.x we returned null.

@philwebb philwebb modified the milestones: 2.2.x, 2.2.0.M6 Sep 4, 2019
@philwebb philwebb closed this in ebae76b Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.