/spring-boot

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Tomcat 7.0.52 #245

Closed
philwebb opened this Issue Jan 21, 2014 · 2 comments

Comments

Assignees
No one assigned
Labels
Projects
None yet
Milestone
  1.0.0.RC4
2 participants
@philwebb @dsyer
@philwebb
Member

philwebb commented Jan 21, 2014

Upgrading to Tomcat 7.0.50 fails with the following exception:

SEVERE: A child container failed during start
java.util.concurrent.ExecutionException: java.lang.ExceptionInInitializerError
    at java.util.concurrent.FutureTask$Sync.innerGet(FutureTask.java:222)
    at java.util.concurrent.FutureTask.get(FutureTask.java:83)
    at org.apache.catalina.core.ContainerBase.startInternal(ContainerBase.java:1123)
    at org.apache.catalina.core.StandardHost.startInternal(StandardHost.java:801)
    at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:150)
    at org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1559)
    at org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1549)
    at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
    at java.util.concurrent.FutureTask.run(FutureTask.java:138)
    at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:895)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:918)
    at java.lang.Thread.run(Thread.java:695)
Caused by: java.lang.ExceptionInInitializerError
    at org.apache.catalina.startup.TldConfig.createTldDigester(TldConfig.java:94)
    at org.apache.catalina.startup.TldConfig.init(TldConfig.java:576)
    at org.apache.catalina.startup.TldConfig.lifecycleEvent(TldConfig.java:559)
    at org.apache.catalina.util.LifecycleSupport.fireLifecycleEvent(LifecycleSupport.java:119)
    at org.apache.catalina.util.LifecycleBase.fireLifecycleEvent(LifecycleBase.java:90)
    at org.apache.catalina.util.LifecycleBase.setStateInternal(LifecycleBase.java:402)
    at org.apache.catalina.util.LifecycleBase.init(LifecycleBase.java:110)
    at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:139)
    ... 7 more
Caused by: java.lang.NullPointerException
    at org.apache.tomcat.util.descriptor.DigesterFactory.idFor(DigesterFactory.java:107)
    at org.apache.tomcat.util.descriptor.DigesterFactory.<clinit>(DigesterFactory.java:59)
    ... 15 more

It looks like this issue was also raise during the release voting:

http://tomcat.10.x6.nabble.com/VOTE-Release-Apache-Tomcat-7-0-50-tp5009609p5009974.html

It seems like we might need to include tomcat-jsp-api.jar which has been discussed previously when we encountered tomcat warnings.

@philwebb philwebb closed this in 3d60696 Jan 21, 2014

@dsyer

This comment has been minimized.

Show comment
Hide comment
@dsyer

dsyer Jan 21, 2014

Member

I think we should roll back to 7.0.47 until this can be addressed as a Tomcat packaging issue (Mark says he will prioritise it):

https://issues.apache.org/bugzilla/show_bug.cgi?id=56045
https://issues.apache.org/bugzilla/show_bug.cgi?id=56044
Member

dsyer commented Jan 21, 2014

I think we should roll back to 7.0.47 until this can be addressed as a Tomcat packaging issue (Mark says he will prioritise it):

https://issues.apache.org/bugzilla/show_bug.cgi?id=56045
https://issues.apache.org/bugzilla/show_bug.cgi?id=56044

@dsyer dsyer reopened this Jan 21, 2014

@philwebb philwebb referenced this issue Jan 21, 2014

Closed

Allow EL without tomcat-jasper #248

@dsyer

This comment has been minimized.

Show comment
Hide comment
@dsyer

dsyer Jan 24, 2014

Member

Those 2 issues ought to be resolved in 7.0.51
Member

dsyer commented Jan 24, 2014

Those 2 issues ought to be resolved in 7.0.51

@philwebb philwebb modified the milestones: 1.0.0.RELEASE, 1.0.0.RC2 Feb 6, 2014

@philwebb philwebb removed the icebox label Feb 24, 2014

@philwebb philwebb closed this in c44f902 Feb 24, 2014

gigfork pushed a commit to boostrack/spring-boot that referenced this issue Apr 21, 2014

Phillip Webb
Upgrade to Tomcat 7.0.50 
Upgrade to Tomcat 7.0.50, working around the potential
NullPointerException by also adding dependencies to
tomcat-embedded-jasper (which is now also required for Hibernate
Validator 5.0, see commit 377953b)

Fixes gh-245
d556adf

gigfork pushed a commit to boostrack/spring-boot that referenced this issue Apr 21, 2014

Phillip Webb
Upgrade to Tomcat 7.0.52 
Fixes gh-245
7600816
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment