Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify behaviour of WebServerFactory in reference guide #24705

Closed
snicoll opened this issue Jan 8, 2021 · 0 comments
Closed

Clarify behaviour of WebServerFactory in reference guide #24705

snicoll opened this issue Jan 8, 2021 · 0 comments
Assignees
Milestone

Comments

@snicoll
Copy link
Member

@snicoll snicoll commented Jan 8, 2021

When one creates its own WebServerFactory bean, the expectation is that Spring Boot backs-off completely and give you full control for configuring the chosen embedded server. This isn't the case as customizers are applied regardless (and most of the auto-configuration job is done there).

We should improve the reference guide to describe that explicitly. See #24574 for an example of exposing the factory instead of a customizer and seeing their changes overwritten by auto-configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant