Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Since 2.3.8 and 2.4.2, the documented index format does not match the implementation #24856

Closed
wilkinsona opened this issue Jan 15, 2021 · 1 comment
Assignees
Milestone

Comments

@wilkinsona
Copy link
Member

@wilkinsona wilkinsona commented Jan 15, 2021

#24192 changed the index to include the directory name in its entries, e.g. dependency.jar became BOOT-INF/lib/dependency.jar. This allowed the entries in the index to match what the JarLauncher looks for when creating its classpath. The docs weren't updated at the same time so they're now out of sync with the implementation. Complicating things further, the Java buildpack looks for the old directory-less format so it has been broken by the change.

@ekcasey has kindly offered to fix the buildpack but I'd like to double-check that we don't want to try to align the implementation with the docs (and therefore with what the buildpack looks for) instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants