Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document ServletListenerRegistrationBean #2518

Closed
rwinch opened this issue Feb 18, 2015 · 2 comments
Closed

Document ServletListenerRegistrationBean #2518

rwinch opened this issue Feb 18, 2015 · 2 comments
Milestone
1.2.2

Comments

@rwinch
Copy link
Member

rwinch commented Feb 18, 2015

Related #1537
@rwinch rwinch mentioned this issue Feb 18, 2015
Closed
@dsyer
Copy link
Member

dsyer commented Feb 18, 2015

You don't need a registration bean for listeners (and it's documented here: http://docs.spring.io/spring-boot/docs/current/reference/htmlsingle/#howto-add-a-servlet-filter-or-servletcontextlistener). Maybe one more sentence to mention that there is a registration bean would help?

@dsyer dsyer closed this as completed in c3c1565 Feb 18, 2015
@dsyer dsyer modified the milestone: 1.2.2 Feb 18, 2015
@rwinch
Copy link
Member Author

rwinch commented Feb 18, 2015

I think the main thing is that scanning the whole document there was no mention of HttpSessionListener. Your commit addresses this. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.2.2
Development

No branches or pull requests
2 participants
@dsyer @rwinch