Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configuration of ciphers is ignored for TCP with Reactory Netty #25913

Closed
snicoll opened this issue Apr 7, 2021 · 2 comments
Closed

Configuration of ciphers is ignored for TCP with Reactory Netty #25913

snicoll opened this issue Apr 7, 2021 · 2 comments
Assignees
@bclozel
Labels
type: bug A general bug
Milestone
2.4.5

Comments

@snicoll
Copy link
Member

snicoll commented Apr 7, 2021

Follow-up of reactor/reactor-netty#1543

There is a new API available, but we need to figure out how we could use it without breaking protected SslContextBuilder getContextBuilder().
@snicoll snicoll added the type: bug A general bug label Apr 7, 2021
@snicoll snicoll added this to the 2.4.x milestone Apr 7, 2021
@snicoll
Copy link
Member Author

snicoll commented Apr 8, 2021

We probably need a test that exercises the scenario described in the linked issue as well.

@bclozel bclozel self-assigned this Apr 8, 2021
@Johannes-Rost
Copy link

Hello @snicoll,

my initial description of the reactor-netty-Bug includes the steps neccessary to reproduce the bug for a Spring Boot application: reactor/reactor-netty#1543 (comment)
Actualy the Bug is - from my point of view - a regression between Spring Boot 2.3 and 2.4. I filed it as a reactor-netty-Bug because it was caused by a modification to reactor.netty.tcp.SslProvider.

I think that it is very difficult to write an automated test for this error, because you would have to examine the resulting SSL configuration of the netty and this configuration does not provide a suitable interface.

If I can be of any help, feel free to let me know.

bclozel added a commit to bclozel/spring-boot that referenced this issue Apr 8, 2021
@bclozel
Fix SSL configuration with Reactor Netty
903be6c 
Prior to this commit, the SslServerCustomizer would use a Reactor Netty
API that lets users customize the SSL configuration, but later override
some of the choices with defaults.

This commits moves from the new deprecated Reactor Netty API and instead
uses a new variant that builds the defaults and lets developers override
them if they want to.

Fixes spring-projectsgh-25913
@bclozel bclozel mentioned this issue Apr 8, 2021
Closed
@bclozel bclozel closed this as completed in a0ee060 Apr 8, 2021
@bclozel bclozel modified the milestones: 2.4.x, 2.4.5 Apr 8, 2021
@violetagg violetagg mentioned this issue Apr 8, 2021
Closed
@bclozel bclozel mentioned this issue Nov 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bclozel bclozel

Labels
type: bug A general bug
Projects
None yet
Milestone
2.4.5
Development

No branches or pull requests
3 participants
@bclozel @snicoll @Johannes-Rost