Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check excluded auto-configuration classes are actually auto-config #6865

Closed
philwebb opened this issue Sep 12, 2016 · 4 comments
Closed

Check excluded auto-configuration classes are actually auto-config #6865

philwebb opened this issue Sep 12, 2016 · 4 comments
Assignees
Labels
type: enhancement A general enhancement
Milestone

Comments

@philwebb
Copy link
Member

See #6861 for one example where this would help. We could check that if the class exists, it should be in the list that would be otherwise included.

@philwebb philwebb added the type: enhancement A general enhancement label Sep 12, 2016
@philwebb philwebb added this to the 1.5.0 M1 milestone Sep 12, 2016
@snicoll
Copy link
Member

snicoll commented Sep 12, 2016

@AutoconfigureAfter/Before is another candidate. I've seen a few users trying to use that thing on regular configuration classes.

@wilkinsona wilkinsona changed the title Check excpluded auto-configuration classes are acutally auto-config Check excluded auto-configuration classes are actually auto-config Sep 12, 2016
@mbhave mbhave self-assigned this Nov 14, 2016
mbhave added a commit to mbhave/spring-boot that referenced this issue Nov 16, 2016
mbhave added a commit to mbhave/spring-boot that referenced this issue Nov 16, 2016
mbhave added a commit to mbhave/spring-boot that referenced this issue Nov 16, 2016
mbhave added a commit to mbhave/spring-boot that referenced this issue Nov 16, 2016
mbhave added a commit to mbhave/spring-boot that referenced this issue Nov 18, 2016
mbhave added a commit to mbhave/spring-boot that referenced this issue Nov 18, 2016
mbhave added a commit to mbhave/spring-boot that referenced this issue Nov 21, 2016
wilkinsona pushed a commit that referenced this issue Nov 22, 2016
@wilkinsona
Copy link
Member

wilkinsona commented Nov 22, 2016

I've merged and closed #7407 but left this open so that we can look at doing something similar for @AutoConfigureBefore and @AutoConfigureAfter

@mbhave
Copy link
Contributor

mbhave commented Dec 7, 2016

@philwebb For the @AutoConfigureBefore and @AutoConfigureAfter, I see two ways in which it could be incorrectly used:

  1. The annotation is used on a class that is not auto-config
  2. The annotation value contains a class that exists but is not auto-config.

Point 2. could be taken care of in the AutoConfigurationSorter but I'm not sure if we also want to fail hard on Point 1. Thoughts?

@mbhave mbhave added the for: team-attention An issue we'd like other members of the team to review label Dec 8, 2016
@mbhave mbhave removed the for: team-attention An issue we'd like other members of the team to review label Dec 16, 2016
@philwebb
Copy link
Member Author

Closing this one as fixed. We'll take on AutoConfigureBefore/AutoConfigureAfter in #7697 which we might slip.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

4 participants