-
Notifications
You must be signed in to change notification settings - Fork 40.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align AbstractFilterRegistrationBean dispatcher types with servlet spec #7467
Comments
It would be cool to be set default values from configuration files. |
This change will mean that |
@wilkinsona see #4505 (comment) please. I still believe that |
Sorry, @cemo, but we're not going to change our decision to use |
Thanks @wilkinsona, really makes sense to align with spec. |
The default dispatcher types defined in
AbstractFilterRegistrationBean
were originally copied fromAbstractDispatcherServletInitializer.getDispatcherTypes()
however they continue to cause problems.Rather than trying to pick our own set we should align with the servlet spec and use
DispatcherType.REQUEST
as the default.We will then need to check our own configuration of filters to see if specified dispatcher types are required for them.
The text was updated successfully, but these errors were encountered: