Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undertow initialises filters lazily so failures are only discovered when the first request is made #9232

Closed
wilkinsona opened this issue May 15, 2017 · 4 comments
Assignees
Milestone

Comments

@wilkinsona
Copy link
Member

@wilkinsona wilkinsona commented May 15, 2017

By contrast:

  • Jetty initialises the filter on startup and the failure causes the app to fail to start
  • Tomcat initialises the filter on startup and the failure leaves the web part of the application in a broken state (#9095 will make it behave like Jetty)

This issue is proposing that we also make Undertow behave like Jetty. We can do so by enabling eager filter init on the DeploymentInfo. We might want to expose a server.undertow.eager-filter-init to allow people to switch back easily (or could just use an UndertowDeploymentInfoCustomizer).

@wilkinsona
Copy link
Member Author

@wilkinsona wilkinsona commented May 15, 2017

I'm not sure if we should fix this in a maintenance release or wait for 2.0. Thoughts?

@philwebb
Copy link
Member

@philwebb philwebb commented May 17, 2017

2.0

@ldcsaa
Copy link

@ldcsaa ldcsaa commented Jan 29, 2019

Thanks~
But how to let undertow initializes filters on startup just like tomcat in spring-boot-1.5.x ?

@wilkinsona
Copy link
Member Author

@wilkinsona wilkinsona commented Jan 29, 2019

Take a look at the commit that closed this issue. If you have any further questions, please follow up on Stack Overflow or Gitter. As mentioned in the guidelines for contributing, we prefer to use GitHub issues only for bugs and enhancements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants