New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undertow initialises filters lazily so failures are only discovered when the first request is made #9232

Closed
wilkinsona opened this Issue May 15, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@wilkinsona
Copy link
Member

wilkinsona commented May 15, 2017

By contrast:

  • Jetty initialises the filter on startup and the failure causes the app to fail to start
  • Tomcat initialises the filter on startup and the failure leaves the web part of the application in a broken state (#9095 will make it behave like Jetty)

This issue is proposing that we also make Undertow behave like Jetty. We can do so by enabling eager filter init on the DeploymentInfo. We might want to expose a server.undertow.eager-filter-init to allow people to switch back easily (or could just use an UndertowDeploymentInfoCustomizer).

@wilkinsona

This comment has been minimized.

Copy link
Member

wilkinsona commented May 15, 2017

I'm not sure if we should fix this in a maintenance release or wait for 2.0. Thoughts?

@philwebb

This comment has been minimized.

Copy link
Member

philwebb commented May 17, 2017

2.0

@philwebb philwebb added this to the 2.0.0.M2 milestone May 17, 2017

@wilkinsona wilkinsona self-assigned this May 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment