Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve LDAP auto-configuration #13136

Closed

Conversation

Projects
None yet
3 participants
@vpavic
Copy link
Member

commented May 10, 2018

Auto-configuration of LDAP's LdapTemplate is currently a part of LdapDataAutoConfiguration which is conditional of presence of LdapRepository (i.e. Spring Data LDAP). This arrangement isn't ideal (and doesn't make much sense) since the LdapTemplate is a part of Spring LDAP project, and therefore should not be tied to Spring Data LDAP.

This PR improves and simplifies LDAP auto-configuration by moving LdapTemplate configuration to LdapAutoConfiguration. Consequently, LdapDataAutoConfiguration is not needed anymore and is removed.

Improve LDAP auto-configuration
Auto-configuration of LDAP's `LdapTemplate` is currently a part of `LdapDataAutoConfiguration` which is conditional of presence of `LdapRepository` (i.e. Spring Data LDAP). This arrangement isn't ideal since the `LdapTemplate` is a part of Spring LDAP project, and therefore should not be tied to Spring Data LDAP.

This commit improves and simplifies LDAP auto-configuration by moving `LdapTemplate` configuration to `LdapAutoConfiguration`. Consequently, `LdapDataAutoConfiguration` is not needed anymore and is removed.

@snicoll snicoll added this to the Backlog milestone May 11, 2018

@snicoll snicoll self-assigned this May 11, 2018

@snicoll snicoll modified the milestones: Backlog, 2.1.0.M1 May 11, 2018

snicoll added a commit that referenced this pull request May 11, 2018

Improve LDAP auto-configuration
Auto-configuration of LDAP's `LdapTemplate` is currently a part of
`LdapDataAutoConfiguration` which is conditional of presence of
`LdapRepository` (i.e. Spring Data LDAP). This arrangement isn't ideal
since the `LdapTemplate` is a part of Spring LDAP project, and therefore
should not be tied to Spring Data LDAP.

This commit improves and simplifies LDAP auto-configuration by moving
`LdapTemplate` configuration to `LdapAutoConfiguration`. Consequently,
`LdapDataAutoConfiguration` is not needed anymore and is removed.

See gh-13136

@snicoll snicoll closed this in a0a0bea May 11, 2018

snicoll added a commit that referenced this pull request May 11, 2018

Merge pull request #13136 from vpavic:improve-ldap-autoconfig
* pr/13136:
  Polish "Improve LDAP auto-configuration"
  Improve LDAP auto-configuration
@snicoll

This comment has been minimized.

Copy link
Member

commented May 11, 2018

Nice one, thanks @vpavic!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.