Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HANA to the lookup of well-known databases #15125

Closed

Conversation

@breglerj
Copy link
Contributor

commented Nov 7, 2018

HANA has been added to the DatabaseDriver enum with PR #14513, but it is still missing in the DatabaseLookup utility class.

@philwebb philwebb added this to the 2.1.x milestone Nov 7, 2018

@snicoll snicoll changed the title Add HANA to the lookup of well-known databases. Add HANA to the lookup of well-known databases Nov 10, 2018

@snicoll snicoll added type: enhancement and removed type: bug labels Nov 10, 2018

@snicoll snicoll self-assigned this Nov 10, 2018

@snicoll snicoll modified the milestones: 2.1.x, 2.1.1 Nov 10, 2018

snicoll added a commit that referenced this pull request Nov 10, 2018

@snicoll snicoll closed this in 089ef90 Nov 10, 2018

snicoll added a commit that referenced this pull request Nov 10, 2018
Merge pull request #15125 from breglerj
* pr/15125:
  Polish "Add HANA to the lookup of well-known databases"
  Add HANA to the lookup of well-known databases
@snicoll

This comment has been minimized.

Copy link
Member

commented Nov 10, 2018

Good catch, HANA was added in Spring Framework 5.1 and we forgot to update our mapping here. I've merged this one with a polish commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.