Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add annotation to support registering Jackson key serializer/deserializers #16544

Closed

Conversation

Projects
None yet
4 participants
@maly7
Copy link
Contributor

commented Apr 12, 2019

Fixes #16469

Updates @JsonComponent so that serializers/deserializers can be registered as key based. Also allows for explicitly declaring the classes the component can handle.

maly7 added some commits Apr 9, 2019

@philwebb

This comment has been minimized.

Copy link
Member

commented Apr 12, 2019

Nice. Thanks @maly7!

philwebb added a commit that referenced this pull request Jun 3, 2019

Support JsonComponent key serializers/deserialzers
Update `@JsonComponent` so that it can also be used to register key
serializers and deserializers.

See gh-16544

@philwebb philwebb closed this in f9f6544 Jun 3, 2019

@philwebb

This comment has been minimized.

Copy link
Member

commented Jun 3, 2019

Thanks @maly7 for your first contribution to Spring Boot! This has now been squashed and merged to master along with a polish commit. I went back and forth a few times trying different attribute names and ended up renaming them to type and scope. I quite like type because it aligns with the parameters that the addSerializer/addDeserializer methods take. I'm less happy with scope since it could be confused with Spring's @Scope annotation, but I couldn't come up with anything better.

Thanks again!

@snicoll snicoll modified the milestones: 2.2.x, 2.2.0.M4 Jun 3, 2019

@maly7

This comment has been minimized.

Copy link
Contributor Author

commented Jun 3, 2019

Thanks, @philwebb!

philwebb added a commit that referenced this pull request Jun 3, 2019

wilkinsona added a commit to wilkinsona/spring-boot that referenced this pull request Jun 4, 2019

Support JsonComponent key serializers/deserialzers
Update `@JsonComponent` so that it can also be used to register key
serializers and deserializers.

See spring-projectsgh-16544

wilkinsona added a commit to wilkinsona/spring-boot that referenced this pull request Jun 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.