Clarify Logback XML #16901
Closed
Clarify Logback XML #16901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simple logging setup is configurable by application properties. "To configure the more fine-grained settings of a logging system, you need to use the native configuration format supported by the LoggingSystem in question" In other words Spring Boot provides default logging configuration + application properties to modify. If application has to customize something not covered by application properties, it must switch to XML configuration. Unfortunately, naive switching to XML cause lost default Spring Boot configuration. But there is an impression, that the lost can be avoided. It is possible tweak low level logging detail by XML and keep default Spring Boot configuration working. It is enough to import files 'base.xml' or 'default.xml'. The impression is wrong. 'defaults.xml' does not setup console nor file logging, just setup levels and properties. 'base.xml' by default logs to file '/tmp/spring.log', what is different than default behavior that nothing is logged to a file. Intention of my commit is to express that files 'base.xml' and 'defaults.xml' are not equivalent of default Spring Boot configuration
spring-projects-issues
added
the
status: waiting-for-triage
philwebb
added
for: merge-with-amendments
|
I agree that that section is a little confusing. I think we ideally need to go a little further than your suggested edits and describe clearly the difference between |
Closed
philwebb
pushed a commit
that referenced
this pull request
Sep 4, 2019
Update documentation and comments on Logback to show the correct use of `default.xml` rather than `base.xml`. See gh-16901
philwebb
added a commit
that referenced
this pull request
Sep 4, 2019
Expand the Logback "How To" to provide further clarifications on the different include files available. See gh-16901
|
Thanks very much for the PR @michaldo. This is now in 2.1.x and 2.2.x. I've also extended the documentation a little to try and clarify when the different include files should be used. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple logging setup is configurable by application properties.
"To configure the more fine-grained settings of a logging system, you
need to use the native configuration format supported by the
LoggingSystem in question"
In other words Spring Boot provides default logging configuration +
application properties to modify. If application has to customize
something not covered by application properties, it must switch to XML
configuration.
Unfortunately, naive switching to XML cause lost default Spring Boot
configuration.
But there is an impression, that the lost can be avoided. It is possible
tweak low level logging detail by XML and keep default Spring Boot
configuration working. It is enough to import files 'base.xml' or
'default.xml'.
The impression is wrong.
'defaults.xml' does not setup console nor file logging, just setup
levels and properties.
'base.xml' by default logs to file '/tmp/spring.log', what is different
than default behavior that nothing is logged to a file.
Intention of my commit is to express that files 'base.xml' and
'defaults.xml' are not equivalent of default Spring Boot configuration