Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quartz may attempt to use the DataSource before migrations have been run #17539

Closed
wants to merge 1 commit into from

Conversation

@nosan
Copy link
Contributor

commented Jul 16, 2019

see gh-17528

@nosan nosan changed the title Ensure that that SchedulerFactoryBean and Scheduler beans depend on the Flyway and Liquibase. Ensure that SchedulerFactoryBean and Scheduler beans depend on the Flyway and Liquibase. Jul 16, 2019
@nosan nosan force-pushed the nosan:gh-17528 branch 2 times, most recently from 1dcbbff to b5a68f5 Jul 16, 2019
@nosan nosan force-pushed the nosan:gh-17528 branch from b5a68f5 to b36c3fc Jul 17, 2019
@wilkinsona wilkinsona changed the title Ensure that SchedulerFactoryBean and Scheduler beans depend on the Flyway and Liquibase. Quartz may attempt to use the DataSource before migrations have been run Jul 17, 2019
@wilkinsona wilkinsona added this to the 2.1.x milestone Jul 17, 2019
Flyway and Liquibase.

see gh-17528
@nosan nosan force-pushed the nosan:gh-17528 branch from b36c3fc to e84b840 Jul 17, 2019
@philwebb philwebb self-assigned this Sep 1, 2019
philwebb added a commit that referenced this pull request Sep 1, 2019
Add post processors to ensure that SchedulerFactoryBean and Scheduler
beans depend on the Flyway and Liquibase beans.

See gh-17539
philwebb added a commit that referenced this pull request Sep 1, 2019
@philwebb philwebb closed this in 0cfcbcb Sep 1, 2019
@philwebb

This comment has been minimized.

Copy link
Member

commented Sep 1, 2019

Thanks yet again @nosan! This has now been merged into 2.1 and forward-ported to 2.2. I changed things slightly in 75a1a24 so @Bean methods are used in favor of multiple @Configuration classes.

@philwebb philwebb modified the milestones: 2.1.x, 2.1.8 Sep 1, 2019
philwebb added a commit that referenced this pull request Sep 2, 2019
See gh-17539
@nosan

This comment has been minimized.

Copy link
Contributor Author

commented Sep 3, 2019

Thank you very much, @philwebb

Just to make sure, I see that @ConditionalOnClass annotations have been removed. Did you really want to remove them or it was done accidentally?

@nosan nosan deleted the nosan:gh-17528 branch Sep 3, 2019
@philwebb

This comment has been minimized.

Copy link
Member

commented Sep 3, 2019

Hi @nosan, That was intentional and @ConditionalOnBean should deal with any ClassNotFoundException.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.