Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Nitrite starter in README #19196

Conversation

@FunThomas424242
Copy link
Contributor

FunThomas424242 commented Nov 29, 2019

Hello,

I have read the hints for pull requests - thanks :)

I have only 2 cents for your README.adoc in the subproject spring-boot-starter.
I have added 1 line to the table of third party spring-boot-starters: Nitrite Database
(Its my first starter project, i hope its meet your quality of starter code.)
But, here in the pull request i have only added 2 links to the nitrite-spring-boot-starter project.

Sorry for my english.

Thanks

Thomas

nitrite spring boot startet added to README.adoc
@pivotal-issuemaster

This comment has been minimized.

Copy link

pivotal-issuemaster commented Nov 29, 2019

@FunThomas424242 Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-issuemaster

This comment has been minimized.

Copy link

pivotal-issuemaster commented Nov 29, 2019

@FunThomas424242 Thank you for signing the Contributor License Agreement!

@philwebb philwebb added this to the 2.1.x milestone Dec 2, 2019
@mbhave

This comment has been minimized.

Copy link
Contributor

mbhave commented Dec 5, 2019

I couldn't find a nitrite-spring-boot-starter version that's compatible with Spring Boot 2.1.x. I think this should go in the 2.2.x milestone.

@mbhave mbhave modified the milestones: 2.1.x, 2.2.x Dec 5, 2019
mbhave added a commit that referenced this pull request Dec 5, 2019
@mbhave mbhave closed this in 37d5f1d Dec 5, 2019
@mbhave

This comment has been minimized.

Copy link
Contributor

mbhave commented Dec 5, 2019

@FunThomas424242 Thank you for making your first contribution to Spring Boot. This has now been merged into 2.2.x and master.

@mbhave mbhave modified the milestones: 2.2.x, 2.2.2 Dec 5, 2019
@mbhave mbhave changed the title add nitrite spring boot starter Document Nitrite starter in README Dec 5, 2019
@FunThomas424242

This comment has been minimized.

Copy link
Contributor Author

FunThomas424242 commented Dec 5, 2019

@mbhave Thank you very much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.