Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid ErrorAttributesOptions#getInclude Javadoc #24257

Closed
wants to merge 1 commit into from
Closed

Invalid ErrorAttributesOptions#getInclude Javadoc #24257

wants to merge 1 commit into from

Conversation

@JimStockwell
Copy link
Contributor

@JimStockwell JimStockwell commented Nov 26, 2020

The JavaDoc return description of ErrorAttributeOptions.getIncludes reads the same as isIncluded's return description.
This pull request corrects the description.

Return description was just incorrect,
maybe copied from the method above it?
@snicoll snicoll self-assigned this Nov 26, 2020
@snicoll snicoll added this to the 2.3.7 milestone Nov 26, 2020
@snicoll snicoll changed the title Correct getIncludes JavaDoc return description Invalid ErrorAttributesOptions#getInclude Javadoc Nov 26, 2020
snicoll added a commit that referenced this pull request Nov 26, 2020
@snicoll snicoll closed this in b4a1030 Nov 26, 2020
@snicoll
Copy link
Member

@snicoll snicoll commented Nov 26, 2020

@JimStockwell good catch and thank you for making your first contribution to Spring Boot.

@JimStockwell JimStockwell deleted the JimStockwell:fix-getIncludes-JavaDoc branch Nov 26, 2020
@JimStockwell
Copy link
Contributor Author

@JimStockwell JimStockwell commented Nov 26, 2020

Thank you. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants