Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OriginTrackedPropertiesLoader#isNewDocument has wrong visibility #24268

Closed
wants to merge 1 commit into from
Closed

OriginTrackedPropertiesLoader#isNewDocument has wrong visibility #24268

wants to merge 1 commit into from

Conversation

@JimStockwell
Copy link
Contributor

@JimStockwell JimStockwell commented Nov 27, 2020

OriginTrackedPropertiesLoader#isNewDocument doesn't seem like
an intended part of the class' public interface,
and it is not called from anywhere outside the class.

OriginTrackedPropertiesLoader#isNewDocument doesn't seem like
an intended part of the class' public interface,
and it is not called from anywhere outside the class.
@snicoll snicoll changed the title Mark OriginTrackedPropertiesLoader#isNewDocument private OriginTrackedPropertiesLoader#isNewDocument has wrong visibility Nov 27, 2020
@snicoll snicoll added this to the 2.4.1 milestone Nov 27, 2020
@snicoll snicoll self-assigned this Nov 27, 2020
@snicoll snicoll closed this in 23543b0 Nov 27, 2020
@snicoll
Copy link
Member

@snicoll snicoll commented Nov 27, 2020

@JimStockwell good catch, thank you!

@JimStockwell
Copy link
Contributor Author

@JimStockwell JimStockwell commented Nov 27, 2020

Thank you!

@JimStockwell JimStockwell deleted the JimStockwell:add-private branch Nov 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants