Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle missing manifest files in JarTypeFilter #24597

Closed
wants to merge 1 commit into from

Conversation

@edwardsre
Copy link
Contributor

@edwardsre edwardsre commented Dec 22, 2020

JarTypeFilter was not handling dependency jars with missing manifest files, resulting in all starter jars being included in repackaged jars.

Fixes gh-24594

JarTypeFilter was not handling dependency jars with missing manifest files, resulting in all starter jars being included in repackaged jars.

Fixes gh-24594
@pivotal-issuemaster
Copy link

@pivotal-issuemaster pivotal-issuemaster commented Dec 22, 2020

@edwardsre Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-issuemaster
Copy link

@pivotal-issuemaster pivotal-issuemaster commented Dec 22, 2020

@edwardsre Thank you for signing the Contributor License Agreement!

@snicoll snicoll added this to the 2.4.x milestone Dec 23, 2020
@snicoll snicoll assigned snicoll and unassigned snicoll Dec 23, 2020
@snicoll snicoll modified the milestones: 2.4.x, 2.4.2 Dec 23, 2020
snicoll added a commit that referenced this pull request Dec 23, 2020
This commit makes sure that a jar file without a manifest is handled
properly (i.e. included in the repackaged archive).

See gh-24597
@snicoll snicoll closed this in 5fa5b62 Dec 23, 2020
@snicoll
Copy link
Member

@snicoll snicoll commented Dec 23, 2020

@edwardsre thank you for making your first contribution to Spring Boot.

@edwardsre edwardsre deleted the edwardsre:gh-24594 branch Dec 23, 2020
snicoll added a commit that referenced this pull request Jan 4, 2021
Polish
See gh-24597
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants