Handle missing manifest files in JarTypeFilter #24597
Closed
Conversation
JarTypeFilter was not handling dependency jars with missing manifest files, resulting in all starter jars being included in repackaged jars. Fixes gh-24594
|
@edwardsre Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@edwardsre Thank you for signing the Contributor License Agreement! |
snicoll
added a commit
that referenced
this pull request
Dec 23, 2020
This commit makes sure that a jar file without a manifest is handled properly (i.e. included in the repackaged archive). See gh-24597
snicoll
added a commit
that referenced
this pull request
Dec 23, 2020
|
@edwardsre thank you for making your first contribution to Spring Boot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
JarTypeFilter was not handling dependency jars with missing manifest files, resulting in all starter jars being included in repackaged jars.
Fixes gh-24594