Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failures when recording metrics in MetricsClientHttpRequestInterceptor may interfere with RestTemplate's main behaviour #24753

Closed
wants to merge 1 commit into from

Conversation

@izeye
Copy link
Contributor

@izeye izeye commented Jan 12, 2021

This PR changes to make MetricsClientHttpRequestInterceptor defensive against metrics recording failures as with the current arrangement a failure from metrics recoding could interfere its main flow.

@wilkinsona wilkinsona changed the title Make MetricsClientHttpRequestInterceptor defensive against metrics recoding failures Make MetricsClientHttpRequestInterceptor defensive against metrics recording failures Jan 12, 2021
@wilkinsona wilkinsona changed the title Make MetricsClientHttpRequestInterceptor defensive against metrics recording failures Failures when recording metrics in MetricsClientHttpRequestInterceptor may interfere with RestTemplate's main behaviour Jan 15, 2021
@wilkinsona wilkinsona added this to the 2.3.x milestone Jan 15, 2021
@snicoll snicoll self-assigned this Jan 18, 2021
@snicoll snicoll modified the milestones: 2.3.x, 2.3.9 Jan 18, 2021
snicoll added a commit that referenced this pull request Jan 18, 2021
snicoll added a commit that referenced this pull request Jan 18, 2021
@snicoll snicoll closed this in 28ed335 Jan 18, 2021
@izeye izeye deleted the izeye:interceptor branch Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants