Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration metadata for logging.charset.* has invalid reference for java.nio.charset.Charset #24851

Conversation

@dreis2211
Copy link
Contributor

@dreis2211 dreis2211 commented Jan 15, 2021

Hi,

this PR fixes the configuration metadata for logging.charset.console and logging.charset.file by adjusting the wrong type information.

I only noticed in IDEA that no warning was shown when I entered a wrong charset encoding.
image
I guess other places consuming the metadata could be affected as well.

Cheers,
Christoph

@wilkinsona
Copy link
Member

@wilkinsona wilkinsona commented Jan 15, 2021

Thanks, @dreis2211. I've opened #24852 to see if we can catch this sort of mistake automatically.

@snicoll snicoll self-assigned this Jan 17, 2021
@snicoll snicoll modified the milestones: 2.4.x, 2.4.3 Jan 17, 2021
@snicoll snicoll changed the title Fix configuration metadata for logging.charset.* properties Configuration metadata for logging.charset.* has invalid reference for java.nio.charset.Charset Jan 17, 2021
@snicoll snicoll closed this in f7c855d Jan 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants