Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the need to use the launcher to be able to use application.* properties in a custom banner #24982

Conversation

@robert-smith-911
Copy link
Contributor

@robert-smith-911 robert-smith-911 commented Jan 24, 2021

This is a documentation update to describe the need to use JarLauncher to use application.* properties in custom banner. This is in response to issue 22519

…ation.* properties in unpacked jars.
@philwebb philwebb added this to the 2.3.x milestone Jan 28, 2021
@wilkinsona wilkinsona changed the title Add documentation the need to use JarLauncher to use applicaiton.* properties in custom banner Document the need to use the launcher to be able to use application.* properties in a custom banner Jan 28, 2021
philwebb added a commit that referenced this pull request Jan 29, 2021
Add a note to the "Customizing the Banner" explaining that you need
to be using the `JarLauncher` to use the `application.*` properties.

See gh-24982
@philwebb philwebb closed this in 745dbaf Jan 29, 2021
@philwebb philwebb modified the milestones: 2.3.x, 2.3.9 Jan 29, 2021
@philwebb
Copy link
Member

@philwebb philwebb commented Jan 29, 2021

Thanks @robert-smith-911. I've merged this to 2.3.x and forward with a slight tweak to the wording since you you don't need the -cp . option when using the JarLauncher.

@robert-smith-911
Copy link
Contributor Author

@robert-smith-911 robert-smith-911 commented Jan 29, 2021

Thanks @philwebb !

@robert-smith-911 robert-smith-911 deleted the robert-smith-911:feature/21705 branch Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants