Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify usage of BufferingApplicationStartup #25075

Closed
wants to merge 1 commit into from

Conversation

@oleg-sukhov
Copy link
Contributor

@oleg-sukhov oleg-sukhov commented Feb 1, 2021

Closes gh-24605

@oleg-sukhov oleg-sukhov force-pushed the oleg-sukhov:gh-24605 branch from f2e3a20 to d5c7e0f Feb 2, 2021
@oleg-sukhov
Copy link
Contributor Author

@oleg-sukhov oleg-sukhov commented Feb 3, 2021

Hello, @mbhave. Could you please have a look why the build was stuck?

@mbhave
Copy link
Contributor

@mbhave mbhave commented Feb 3, 2021

Probably due to some network issue in the build infrastructure. The most recent run is green.

@snicoll snicoll self-assigned this Feb 9, 2021
@snicoll snicoll modified the milestones: 2.4.x, 2.4.3 Feb 9, 2021
snicoll added a commit that referenced this pull request Feb 9, 2021
snicoll added a commit that referenced this pull request Feb 9, 2021
@snicoll snicoll closed this in 1c5b802 Feb 9, 2021
@snicoll
Copy link
Member

@snicoll snicoll commented Feb 9, 2021

@oleg-sukhov thank you for making your first contribution to Spring Boot. I've polished is slightly to refer to the actuator endpoint API documentation so that we avoid stating the same thing several times. Also, 2.5.x has now a GET endpoint so the default behavior won't drain the buffer anymore and that is explained there for the 2.5.x version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants