Fix package name for mainClassName in build.gradle of spring-boot-sample-web-ui #3588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, have you signed the CLA? |
|
@snicoll I haven't. It says that I assume a single line change counts as |
|
Better be safe than sorry. If that's not a problem, just sign the damn thing please ;) |
|
@snicoll Done! |
snicoll
added a commit
that referenced
this pull request
Jul 23, 2015
Since each sample has (supposedly) only one application class and not a lot of the code, the `mainClassName` attribute in the gradle build is not really useful and can lead to inconsistency if the application class is moved. See gh-3588
snicoll
added a commit
that referenced
this pull request
Jul 23, 2015
* pr/3588: Remove unnecessary mainClassName Fix package name of web-ui sample
|
Merged, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The package name for the main class in build.gradle is incorrectly set to:
mainClassName = "sample.ui.SampleWebUiApplication"It should be set to:
mainClassName = "sample.web.ui.SampleWebUiApplication"