Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

[BS-48] Add autoconfigured JMS support #49

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
2 participants
Member

gregturn commented Sep 16, 2013

  • Add ability to detect spring-jms on the path and create a JmsTemplate with ActiveMQConnectionFactory
  • Create tests showing autoconfigured JmsTemplate with ActiveMQ, but prove it backs off if a separate ConnectionFactory exists.
  • Add support to spring-boot-cli to that it detects JmsTemplate, DefaultMessageListenerContainer or SimpleMessageListenerContainer, and turns on autoconfiguration as well as add proper @grab's and import statements.
  • Write a jms.groovy test showing proper CLI support
@gregturn gregturn [BS-48] Add autoconfigured JMS support
* Add ability to detect spring-jms on the path and create a JmsTemplate with
  ActiveMQConnectionFactory
* Create tests showing autoconfigured JmsTemplate with ActiveMQ, but prove it
  backs off if a separate ConnectionFactory exists.
* Add support to spring-boot-cli to that it detects JmsTemplate, DefaultMessageListenerContainer,
  or SimpleMessageListenerContainer, and turns on autoconfiguration as well as
  add proper @Grab's and import statements.
* Write a jms.groovy test showing proper CLI support
cd37323
Owner

dsyer commented Sep 18, 2013

Any reason not to simply use @ConditionalOnClass to detect ActiveMQ (seems to be pretty much all you do in the custom condition)? ActiveMQ version is really old as well? If we get those things sorted out I'd want to maybe use some spring.jms.* properties to configure the ConnectionFactory. Otherwise looks good. Thanks for doing the Groovy integration too!

Member

gregturn commented Sep 18, 2013

Somehow I thought testing for activemq would have pulled it in. I can fix that. Didn't realize the version number was so old. Will do.

Member

gregturn commented Sep 18, 2013

P.S. I'm already drafting a blog entry capturing this process. I think it provides a nice insight into how Spring Boot works.

Owner

dsyer commented Sep 18, 2013

Merged, thanks. If you'd like to play around with a different JMS provider and find some spring.jms.* and spring.activemq.* properties that make sense for quick switching of defaults or setting up the ConnectionFactory that would be awesome (I know you have another provider in mind - maybe they both accept a URL as input to the ConnectionFactory or something?). We should have a proper think about what production defaults should look like as well for ActiveMQ.

@dsyer dsyer closed this Sep 18, 2013

@gregturn gregturn deleted the gregturn:BS-48 branch Sep 18, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment