New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reactive mongodb sample #9761
Conversation
Adds entry to readme doc about reactive-mongodb
I'm not sure about the example. The code shows reactive API usage within a synchronous piece of code ( |
@mp911de agreed that block shouldn't be used. what is the reactive equivalent of I have used this in my WebFlux project and copy pasted from there,hence it makes sense there but not here. |
@mp911de Can you please review my latest changes and let me know if I need to improve on anything in this PR |
I am not sure we should add a reactive/non reactive variant of each spring data sample, especially considering how the setup is similar. It feels to me that a Spring Data sample is a better place for it and perhaps such sample already exists. Let's see what the rest of the team thinks. |
We have a few samples in our Spring Data Examples repository. We aren't entirely happy with our current samples because the majority of environments ( A reactive sample would make sense in the context of WebFlux, but then it's no longer a pure MongoDB example. |
I agree with @snicoll, there's no point in adding all the possible variants out there, especially when the setup is so similar. Now about the We could create something like: @FunctionalInterface
public interface ReactiveCommandLineRunner {
Mono<Void> run(String... args);
} At processing time, we would need to concat all of them (to guarantee a processing order) and block, like: firstMono.concatWith(secondMono).then().block(); What do you think? |
@bclozel thanks for the reminder. Can we move the |
adds spring-boot-data-mongdb-responsive sample using new spring data mongodb reactive starter