Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add final modifier to AbstractClusterConfiguration#cluster() and AbstractSessionConfiguration#session() [DATACASS-78] #214

Closed
spring-projects-issues opened this issue Jan 27, 2014 · 3 comments
Closed

Add final modifier to AbstractClusterConfiguration#cluster() and AbstractSessionConfiguration#session() [DATACASS-78] #214

spring-projects-issues opened this issue Jan 27, 2014 · 3 comments
Labels
in: core Issues in core support status: declined A suggestion or change that we don't feel we should currently apply type: bug A general bug

Comments

@spring-projects-issues
Copy link

David Webb opened DATACASS-78 and commented

Add final modifier to cluster() and final().

Add example minimal JavaConfig to readme.md

Affects: 1.0 M1 (Dijkstra)
@spring-projects-issues
Copy link
Author

Matthew T. Adams commented

Note: as of this writing, AbstractCassandraConfiguration has been split into "AbstractClusterConfiguration" & "AbstractSessionConfiguration extends AbstractClusterConfiguration"

@spring-projects-issues
Copy link
Author

Matthew T. Adams commented

Why final on the methods?

@spring-projects-issues
Copy link
Author

Matthew T. Adams commented

Might make it difficult for edge cases to be supported

@spring-projects-issues spring-projects-issues added type: bug A general bug status: declined A suggestion or change that we don't feel we should currently apply in: core Issues in core support labels Dec 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in: core Issues in core support status: declined A suggestion or change that we don't feel we should currently apply type: bug A general bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@spring-projects-issues