Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom implementations in CDI repositories [DATACASS-149] #296

Closed
spring-projects-issues opened this issue Aug 7, 2014 · 10 comments
Labels
in: core type: enhancement

Comments

@spring-projects-issues
Copy link

spring-projects-issues commented Aug 7, 2014

Oliver Drotbohm opened DATACASS-149 and commented


Issue Links:

  • DATACMNS-557 Add support for custom implementations in CDI
    ("depends on")

Referenced from: commits d069bca

@spring-projects-issues
Copy link
Author

spring-projects-issues commented Aug 7, 2014

Mark Paluch commented

There is currently no CDI impl at all. I'll add CDI support for spring-data-cassandra (and minor fixes like typos)

@spring-projects-issues
Copy link
Author

spring-projects-issues commented Aug 8, 2014

Mark Paluch commented

Changes see PR #17

@spring-projects-issues
Copy link
Author

spring-projects-issues commented Aug 26, 2014

Mark Paluch commented

I'll rework the PR according to DATACMNS-557 as soon as the code for DATAJPA-593 is accepted as solution

@spring-projects-issues
Copy link
Author

spring-projects-issues commented Aug 27, 2014

Mark Paluch commented

Fixed CDI custom repository implementation pickup and added to existing PR, see DATACMNS-565 for details

@spring-projects-issues
Copy link
Author

spring-projects-issues commented Sep 1, 2014

Oliver Drotbohm commented

David Webb Are you okay with me merging the PR?

@spring-projects-issues
Copy link
Author

spring-projects-issues commented Sep 4, 2014

Oliver Drotbohm commented

Hey guys, any update on this? We're shooting for a release tomorrow and I'd like to get that feature into it

@spring-projects-issues
Copy link
Author

spring-projects-issues commented Sep 4, 2014

David Webb commented

Oliver, I don't even know what to look for here. I trust your judgement on what the pull request provides and if it is correct.

@spring-projects-issues
Copy link
Author

spring-projects-issues commented Sep 4, 2014

Mark Paluch commented

Oliver Drotbohm I propose to postpone the merge. This PR provides initial CDI support for spring data cassandra and I bet no one else has given the impl a test-drive. I vote for a shift towards the next release so this feature has a chance to be tested in a RC or at least in a BUILD-SNAPSHOT

@spring-projects-issues
Copy link
Author

spring-projects-issues commented Sep 4, 2014

Oliver Drotbohm commented

Appreciate your votes guys. Unscheduling and targeting the next release

@spring-projects-issues
Copy link
Author

spring-projects-issues commented Sep 17, 2014

Matthew T. Adams commented

Pulled into master (d069bca)

@spring-projects-issues spring-projects-issues added type: enhancement in: core labels Dec 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core type: enhancement
Projects
None yet
Development

No branches or pull requests

1 participant