Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional return type for Repositories returns Optional of resultset instead of Optional of Objectype [DATACASS-247] #423

Closed
spring-projects-issues opened this issue Jan 5, 2016 · 2 comments

Comments

@spring-projects-issues
Copy link

@spring-projects-issues spring-projects-issues commented Jan 5, 2016

Magesh opened DATACASS-247 and commented

In JAVA 8 when the return type of a repository call Optional<T>, the actual return type is Optional<ResultSet>

Upon invoking Optional::get, I get a:
java.lang.ClassCastException: com.datastax.driver.core.ArrayBackedResultSet$SinglePage cannot be cast to classType

Class:
AbstractCassandraQuery


Affects: 1.3.2 (Gosling SR2)

Issue Links:

  • DATACASS-255 Initial test-cleanup
    ("depends on")
  • DATACASS-280 Refactor Cassandra query execution and mapping to consolidate mapping
    ("is superseded by")

Referenced from: pull request #53, and commits 4772c5b

1 votes, 3 watchers

@spring-projects-issues
Copy link
Author

@spring-projects-issues spring-projects-issues commented May 10, 2016

John Blum commented

Magesh or @MarkPaluch, is there an actual PR for this somewhere? Or is it that the affected code (i.e. AbstractCassandraQuery) just needs to be reviewed and issue/bug reproduced?

Magesh have you or are you able to write a test case that reproduces and demonstrates this issue?

Thanks!

@spring-projects-issues
Copy link
Author

@spring-projects-issues spring-projects-issues commented May 10, 2016

Mark Paluch commented

John Blum I added the test with Cassandra PR 53. The fix required some additional changes so I decided to supersede this ticket with DATACASS-280. The bug resolves (itself) by putting the mapping and conversion into the right place

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants