Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split metadata verifier for Entities and PrimaryKey types [DATACASS-258] #433

Closed
spring-projects-issues opened this issue Mar 10, 2016 · 2 comments
Assignees
Labels
type: task

Comments

@spring-projects-issues
Copy link

@spring-projects-issues spring-projects-issues commented Mar 10, 2016

Mark Paluch opened DATACASS-258 and commented

Currently one metadata verifier (BasicCassandraPersistentEntityMetadataVerifier) is used to check for several cases (Has @Table annotation, has @PrimaryKeyClass annotation) with one method. The issue is that errors are reported back in a confusing way to the user:

Cassandra entities must have the @Table, @Persistent or @PrimaryKeyClass Annotation

Split the verifier into multiple verifications that are used according to the expected type and improve error messages


Issue Links:

  • DATACASS-172 Add support for User-defined types
    ("is depended on by")

Referenced from: pull request #83, and commits c3700ee, fac4323, e238e48, 3e8f984

@spring-projects-issues
Copy link
Author

@spring-projects-issues spring-projects-issues commented Apr 28, 2016

Mark Paluch commented

We should rethink also about logging here as logging always the exception and throwing it is discouraged

@spring-projects-issues
Copy link
Author

@spring-projects-issues spring-projects-issues commented Oct 18, 2016

John Blum commented

SD Cassandara PR 83 reviewed, polished and merged to master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task
Projects
None yet
Development

No branches or pull requests

2 participants