Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Cassandra query execution and mapping to consolidate mapping [DATACASS-280] #452

Closed
spring-projects-issues opened this issue Apr 27, 2016 · 2 comments
Assignees

Comments

@spring-projects-issues
Copy link

@spring-projects-issues spring-projects-issues commented Apr 27, 2016

Mark Paluch opened DATACASS-280 and commented

AbstractCassandraQuery and CassandraTemplate perform both conversions when executing queries. Some return types cannot be obtained from the CassandraTemplate in a generic way but must be retrieved by calling lower level methods such as queryForObject.

AbstractCassandraQuery utilizes complex conditionals to execute queries and so wrapping results in wrapper types (Optional, Future, Stream) is quite complex to achieve.

Changes:

  • Pull mapping from AbstractCassandraQuery into AbstractCassandraConverter
  • Refactor conditional execution to CassandraQueryExecution pattern
  • Follow CassandraConverters and CustomConversions pattern such as in other Spring Data Modules
  • Introduce DtoInstantiatingConverter
  • Refactor ResultSet converters to Row converters

Issue Links:

  • DATACASS-255 Initial test-cleanup
    ("depends on")

  • DATACASS-128 Improve mapping specifications between Cassandra & Java

  • DATACASS-247 Optional return type for Repositories returns Optional of resultset instead of Optional of Objectype
    ("supersedes")

  • DATACASS-295 Add an easy way to configure auto json/xml serialization to cassandra text types
    ("supersedes")

Referenced from: pull request #53, and commits 183c502, 4772c5b

@spring-projects-issues
Copy link
Author

@spring-projects-issues spring-projects-issues commented Apr 29, 2016

Mark Paluch commented

-Renamed and reorganized test structure should be applied on top of the PR for this ticket. Code is located on branch DATACASS-280-rename-move-all-tests-

@spring-projects-issues
Copy link
Author

@spring-projects-issues spring-projects-issues commented May 10, 2016

John Blum commented

Code review complete!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants