SortHandlerMethodArgumentResolver fails to fall back to default if empty parameter is given [DATACMNS-753]

[spring-projects-issues]

Ruben Dijkstra opened DATACMNS-753 and commented

When the sort parameter is empty (?sort=) it becomes a non-null, empty String.
The current logic does not handle this case properly when the handler method is annotated with SortDefault or SortDefaults.

I have provided the PR with the test case.
(If you want a specific target branch, then let me know. If you want to backport it to different branches then do so)

Proposed fix:

String[] directionParameter = webRequest.getParameterValues(getSortParameter(parameter));

Sort sort = null;
if (directionParameter != null && directionParameter.length != 0) {
	sort = parseParameterIntoSort(directionParameter, propertyDelimiter);
}
// if sort ends up empty
if (sort == null) {
	return getDefaultFromAnnotationOrFallback(parameter);
} else {
	return sort;
}

---

Issue Links:

• DATACMNS-408 Guard against invalid values when resolving pagination and sorting parameters from web requests

Referenced from: pull request #138

Backported to: 1.11.1 (Gosling SR1), 1.10.3 (Fowler SR3)

[spring-projects-issues]

Oliver Drotbohm commented

That's merged and fixed in master as well as the bugfix branches for Gosling and Hopper