Out of the box Pageable JSON deserializer [DATACMNS-758]

[spring-projects-issues]

Filip Hrisafov opened DATACMNS-758 and commented

While trying out some projects with spring data I realized that there is not out of the box deserializer from JSON to Pageable.

I saw that there is the PageableHandlerMethodArgumentResolver which is used to resolve Pageable objects from the query string. I think that it might be a good a thing if there is somtething similar that can be used to automatically create Pageable objects from JSON.

A use case for this would be to use Pageable objects in objects that are being send with JSON.

I am sorry if this is the wrong place for this issue. Please let me know where I should submit it if this is not the place

---

No further details from DATACMNS-758

[spring-projects-issues]

Jens Schauder commented

Having a Pageable as part of another object sounds not like a very common scenario to me.

Therefore I'm marking this issue as "not likely" and will close it if no new arguments in favor of it a brought forward

[spring-projects-issues]

Filip Hrisafov commented

Why do you think it is not a common scenario?

We have objects with complex search criterias, apart from the different custom criteria that we have, we want to sent Pageable information to the server and directly give it to the Repository. Having this allows out of the box support for paging and sorting

[spring-projects-issues]

Oliver Drotbohm commented

That's in place with PageableHandlerMethodArgumentResolver constructing a PageRequest from request parameters, isn't it?

[spring-projects-issues]

Filip Hrisafov commented

Yes it is. However, that works only if you send the Pageable via query parameters and not via POST for example.

Is the suggestion to use query parameters for the Pageable with POST requests?

[spring-projects-issues]

Oliver Drotbohm commented

I'd love to learn about an example where sending that information via the request body makes sense. PageRequest is usually used to limit the response for collection resources, for which request parameters make perfect sense. You're still free to implement a custom Jackson deserializer, I just currently don't see this as a scenario common enough to promote it to ship out of the box

[spring-projects-issues]

Filip Hrisafov commented

I figured that it is not a common scenario to be considered shipping it out of the box. A custom Jackson deserializer does the work.You can close the issue if you want to