Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Java 8 and adapt APIs [DATACMNS-867] #1327

Closed
spring-projects-issues opened this issue Jun 8, 2016 · 3 comments
Closed

Upgrade to Java 8 and adapt APIs [DATACMNS-867] #1327

spring-projects-issues opened this issue Jun 8, 2016 · 3 comments
Assignees
Labels
in: core type: dependency-upgrade
Milestone

Comments

@spring-projects-issues
Copy link

@spring-projects-issues spring-projects-issues commented Jun 8, 2016

Oliver Drotbohm opened DATACMNS-867 and commented


Issue Links:

  • DATAJPA-1064 Integrate Data Commons Java 8 upgrade branch
    ("is depended on by")

  • DATAMONGO-1609 Integrate Data Commons Java 8 upgrade branch
    ("is depended on by")

  • DATAREST-1008 Adapt to Java 8 API changes in Spring Data Commons
    ("is depended on by")

  • DATACASS-389 Java 8 code cleanup
    ("is depended on by")

  • DATACOUCH-273 Integrate Data Commons Java 8 upgrade branch
    ("is depended on by")

  • DATAES-328 Integrate Data Commons Java 8 upgrade branch
    ("is depended on by")

  • DATAGRAPH-965 Integrate Data Commons Java 8 upgrade branch
    ("is depended on by")

  • DATAKV-159 Integrate Data Commons Java 8 upgrade branch
    ("is depended on by")

  • DATALDAP-21 Integrate Data Commons Java 8 upgrade branch
    ("is depended on by")

  • DATASOLR-358 Integrate Data Commons Java 8 upgrade branch
    ("is depended on by")

  • SGF-595 Integrate Spring Data Commons Java 8 support
    ("is depended on by")

  • DATACMNS-1018 Reinstantiate ability to customize repository factory bean through annotation and XML namespace

  • DATACMNS-1019 Consider returning Streamable instead of Iterable from core repository interfaces

  • DATACMNS-1015 Introduce IdentifierAccessor.getRequiredIdentifier()

  • DATACMNS-1014 Remove support for JodaTime's deprecated DateMidnight

  • DATACMNS-1148 Return primitive boolean in PartTree.isExistsProjection(...)

  • DATACMNS-1010 Unable to use Pagable in dataset larger than Integer.MAX_VALUE
    ("supersedes")

0 votes, 5 watchers

@spring-projects-issues
Copy link
Author

@spring-projects-issues spring-projects-issues commented Nov 24, 2016

Lovro Pandžić commented

It would be great if findOne(id) and findOne(Predicate) methods returned Optional.

Also, it would be great if QueryDslPredicateExecutor#findAll methods returned List instead of Iterable as converting Iterable -> Stream is a lot more cumbersome compared to List -> Stream. One thing to consider is to switch to Stream as default and then the user can decide what he wants to do with it?

@spring-projects-issues
Copy link
Author

@spring-projects-issues spring-projects-issues commented Nov 24, 2016

Oliver Drotbohm commented

The former is already in place in the feature branch.

The latter is more problematic. The reason we use Iterable here is the we don't want to dictate implementations to have to collect all the data into a List upfront and we most certainly won't gonna switch to that. Returning a Stream in the first place is not an option either as it can only be consumed once. Currently the feature branch contains a type Streamable that extends and works on Iterable instances and has a stream() method that will just return a default, non-parallel stream. That gives you the convenience of being able to get a Stream easily but also allows implementations to work with Iterable instances in their implementation and just return a Streamable.of(iterable) eventually

@spring-projects-issues
Copy link
Author

@spring-projects-issues spring-projects-issues commented Mar 24, 2017

Oliver Drotbohm commented

This is in place now. I've created DATACMNS-1019 to think about the Streamable feature as a follow up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core type: dependency-upgrade
Projects
None yet
Development

No branches or pull requests

2 participants