Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch constructor injection of the repository interface for repository factory beans [DATACMNS-891] #1349

Closed
spring-projects-issues opened this issue Aug 9, 2016 · 0 comments
Assignees
Labels
type: enhancement

Comments

@spring-projects-issues
Copy link

@spring-projects-issues spring-projects-issues commented Aug 9, 2016

Oliver Drotbohm opened DATACMNS-891 and commented

The resolution of the actual bean type produced by repository factories is currently implemented by a predicting BeanPostProcessor. That causes issues for BeanFactoryPostProcessor instances that want to tweak the application context setup by making type based decisions. An instance of that is the automatic replacement of beans with mock instances in Spring Boot 1.4.

If we switched to constructor injection of the repository interface into the factory, the repository interface would even be handed to it for type predicting purposes on the actual factory. We could get rid off the special BeanPostProcessor and make the Boot use case work


Issue Links:

  • DATACASS-369 Adapt API in RepositoryFactoryBeanSupport implementation
    ("is depended on by")
  • DATACOUCH-262 Adapt API in RepositoryFactoryBeanSupport implementation
    ("is depended on by")
  • DATAES-315 Adapt API in RepositoryFactoryBeanSupport implementation
    ("is depended on by")
  • DATAGRAPH-939 Adapt API in RepositoryFactoryBeanSupport implementation
    ("is depended on by")
  • DATAKV-153 Adapt API in RepositoryFactoryBeanSupport implementation
    ("is depended on by")
  • DATALDAP-9 Adapt API in RepositoryFactoryBeanSupport implementation
    ("is depended on by")
  • DATAMONGO-1566 Adapt API in RepositoryFactoryBeanSupport implementation
    ("is depended on by")
  • DATAREDIS-583 Adapt API in RepositoryFactoryBeanSupport implementation
    ("is depended on by")
  • DATASOLR-344 Adapt API in RepositoryFactoryBeanSupport implementation
    ("is depended on by")
  • DATACMNS-892 Expose repository interface via attribute on bean definition for repository factory beans
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement
Projects
None yet
Development

No branches or pull requests

2 participants