Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve memory consumption of Parameter and Parameters [DATACMNS-925] #1378

Closed
spring-projects-issues opened this issue Oct 5, 2016 · 5 comments
Assignees
Labels
in: core type: enhancement

Comments

@spring-projects-issues
Copy link

@spring-projects-issues spring-projects-issues commented Oct 5, 2016

Christoph Dreis opened DATACMNS-925 and commented

Hey,

I recently noticed in our loadtests a small but noticeable heap pressure coming from Parameters and Parameter. Some ArrayLists are initialized without an initial capacity although they are known in those cases - which in the end is not critical but also not optimal. Additionally, there is one call to gather the return type of a method, that constructs a ClassTypeInformation and the underlying map for the type variables which could be saved in some cases.

I attached a small PR to optimize those places.

Cheers,
Christoph


Referenced from: pull request #180

Backported to: 1.12.5 (Hopper SR5)

@spring-projects-issues
Copy link
Author

@spring-projects-issues spring-projects-issues commented Oct 6, 2016

Oliver Drotbohm commented

Well spotted! I've left a few comments on the proposed PR. Happy to merge it beyond that

@spring-projects-issues
Copy link
Author

@spring-projects-issues spring-projects-issues commented Oct 7, 2016

Christoph Dreis commented

Have commented it myself. Thanks for taking the time!

@spring-projects-issues
Copy link
Author

@spring-projects-issues spring-projects-issues commented Oct 16, 2016

Christoph Dreis commented

I hope you don't mind if I ask for feedback on the PR (again)

@spring-projects-issues
Copy link
Author

@spring-projects-issues spring-projects-issues commented Oct 16, 2016

Oliver Drotbohm commented

Sorry about the delay, stuck in travel /o. All good, about to merge it, with that tiny tweak

@spring-projects-issues
Copy link
Author

@spring-projects-issues spring-projects-issues commented Oct 16, 2016

Christoph Dreis commented

You're the man. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core type: enhancement
Projects
None yet
Development

No branches or pull requests

2 participants