Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Vavr's Try as query method return value [DATACMNS-983] #1403

Closed
spring-projects-issues opened this issue Jan 28, 2017 · 2 comments
Closed
Assignees
Labels
type: enhancement

Comments

@spring-projects-issues
Copy link

@spring-projects-issues spring-projects-issues commented Jan 28, 2017

andi opened DATACMNS-983 and commented

Since Javaslang Option support was added in DATACMNS-937, would it also be possible to add support for Javaslang's Try?

Good to have so we can call the repository without try-catch (if any exception)


Affects: 1.13 GA (Ingalls)

Issue Links:

  • SPR-15806 Allow transaction control via well-known method return types
@spring-projects-issues
Copy link
Author

@spring-projects-issues spring-projects-issues commented May 17, 2018

Oliver Drotbohm commented

We'll be looking into this in the context of SPR-15806. Note, that you don't have to use try/catch currently but would rather wrap the repository invocation into a Try.of(() -> repository.findByWhatever(…))

@spring-projects-issues
Copy link
Author

@spring-projects-issues spring-projects-issues commented May 17, 2018

Oliver Drotbohm commented

I've put a draft into the feature branch for this ticket (try by changing your Spring Data Commons dependency to 2.1.0.DATACMNS-983-SNAPSHOT, make sure you are generally running the Lovelace train, e.g. by setting spring-data-releasetrain.version in a Boot application to Lovelace-BUILD-SNAPSHOT). it's not really integration tested yet but you might give it a try already

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement
Projects
None yet
Development

No branches or pull requests

2 participants