Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aggregate event publication should happen after the interaction with the repository [DATACMNS-975] #1429

Closed
spring-projects-issues opened this issue Jan 13, 2017 · 0 comments
Closed

Aggregate event publication should happen after the interaction with the repository [DATACMNS-975] #1429

spring-projects-issues opened this issue Jan 13, 2017 · 0 comments
Assignees
@odrotbohm
Labels
in: repository type: enhancement
Milestone
2.0 M2 (Kay)

Comments

@spring-projects-issues
Copy link

@spring-projects-issues spring-projects-issues commented Jan 13, 2017

Oliver Drotbohm opened DATACMNS-975 and commented

We currently publish events before we actually invoke the save(…) operation on the repository. This leaves the risks of event listeners trying to lookup the aggregate again and not see the pending changes to its state.

We should flip those operations to make sure an exception thrown by the repository method would already prevent the event publication

Affects: 1.13 RC1 (Ingalls)

Referenced from: commits 9ada55b, db17a28

Backported to: 1.13 GA (Ingalls)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@odrotbohm odrotbohm

Labels
in: repository type: enhancement
Projects
None yet
Milestone
2.0 M2 (Kay)
Development

No branches or pull requests
2 participants
@odrotbohm @spring-projects-issues