Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CustomRepositoryImplementationDetector ignores excludeFilters [DATACMNS-989] #1439

Closed
spring-projects-issues opened this issue Feb 9, 2017 · 0 comments
Assignees
Labels
in: repository type: bug
Milestone

Comments

@spring-projects-issues
Copy link

@spring-projects-issues spring-projects-issues commented Feb 9, 2017

Peter Rietzler opened DATACMNS-989 and commented

org.springframework.data.repository.config.CustomRepositoryImplementationDetector#detectCustomImplementation scans all base packages, but ignores excludeFilters.

This leads e.g. to problems if there are 2 classes with the same name on the classpath, but one of them should be ignored, e.g.

xxx.MyRepository
xxx.impl.MyRepositoryImpl
xxx.whatever.MyRepositoryImpl

I've set the excludeFilters for xxx.whatever.*, but still get:

Caused by: java.lang.IllegalStateException: Ambiguous custom implementations detected! Found xxx.impl.MyRepositoryImpl,xxx.whatever.MyRepositoryImpl but expected a single implementation!


Referenced from: pull request #195

Backported to: 1.13.1 (Ingalls SR1), 1.12.8 (Hopper SR8)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: repository type: bug
Projects
None yet
Development

No branches or pull requests

2 participants