Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redeclared reactive delete(Serializable) results in wrong method overload to be invoked eventually [DATACMNS-1023] #1472

Closed
spring-projects-issues opened this issue Mar 30, 2017 · 0 comments
Assignees
Labels
in: repository type: bug
Milestone

Comments

@spring-projects-issues
Copy link

@spring-projects-issues spring-projects-issues commented Mar 30, 2017

Mark Paluch opened DATACMNS-1023 and commented

Redeclaring an overloaded method might invoke another existing method because of parameter assignability.

Consider following repository declaration:

interface RxJava2ConvertingRepository extends Repository<Object, Long> {

	Completable delete(Serializable id);
}

backed by a repository ReactiveSortingRepository<Object, Serializable>.

Invoking delete(serializable) may execute delete(Object), declared in the backing repository instead of delete(serializable).

Method selection does not consider direct matches but relies on the order of Class.getMethods to verify parameter assignability


Affects: 2.0 M1 (Kay)

Issue Links:

  • DATACMNS-943 Redeclared save(Iterable) results in wrong method overload to be invoked eventually

  • DATACMNS-988 Provide RxJava 2 Repository interfaces

Referenced from: commits c247ee9, d87cb03, e737103

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: repository type: bug
Projects
None yet
Development

No branches or pull requests

2 participants