Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent nullability constraints in PageImpl Javadoc [DATACMNS-1236] #1675

Closed
spring-projects-issues opened this issue Dec 13, 2017 · 0 comments
Assignees

Comments

@spring-projects-issues
Copy link

@spring-projects-issues spring-projects-issues commented Dec 13, 2017

Fabrice Daugan opened DATACMNS-1236 and commented

In class "org.springframework.data.domain.PageImpl", the field "pageable" is considered as nullable :

the paging information, can be {@literal null}.

But the super class org.springframework.data.domain.Chunk, owns the same field, same name and considered as not null :

pageable must not be {@literal null}.
...
Assert.notNull(pageable, "Pageable must not be null!");

Two issues :

  • Duplicate field -> either use the getter from Chunk#getPageable(), either make it protected
  • Make not Null the constructor "pageable" parameter of PageImpl

Affects: 2.0.2 (Kay SR2)

Referenced from: pull request #266, and commits e30928d, 6bb7e2b, 6cb8b35, 9dad23d

Backported to: 2.0.3 (Kay SR3)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants