Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify is-new-detection for entities in mapping package [DATACMNS-1333] #1771

Closed
spring-projects-issues opened this issue May 31, 2018 · 0 comments
Assignees
Labels
in: mapping type: enhancement

Comments

@spring-projects-issues
Copy link

spring-projects-issues commented May 31, 2018

Oliver Drotbohm opened DATACMNS-1333 and commented

For historic reasons, we currently have multiple places in which identifier lookups and the algorithm for the is-new-detection is implemented. Originally implemented in the EntityInformation abstraction (which was tied to repositories), we now also keep a similar implementation in IsNewStrategy used via a factory mostly from the auditing subsystem.

We should move to unify these approaches in PersistentEntity as we already implement the identifier and property lookup there, allow store specific overrides. This also means that repository implementations could work with PersistentEntity instead of EntityInformation. As this would require more intensive refactoring, we could refactor the PersistentEntityInformation implementation to completely delegate to PersistentEntity and deprecate all related implementations of EntityInformation (the one handling Persistable etc.).

Also, we should deprecate IsNewStrategyFactory and rather move IsNewAwareAuditingHandler onto the is-new-detection to be exposed from PersistentEntity


Issue Links:

  • DATAMONGO-1990 Adapt build to changes in is-new-handling
    ("is depended on by")
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: mapping type: enhancement
Projects
None yet
Development

No branches or pull requests

2 participants