Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong assertion in AuditingBeanDefinitionRegistrarSupport [DATACMNS-1453]

Closed
spring-projects-issues opened this issue Dec 19, 2018 · 0 comments
Assignees
Labels
in: core type: enhancement

Comments

@spring-projects-issues
Copy link

spring-projects-issues commented Dec 19, 2018

fsoleraracil opened DATACMNS-1453 and commented

There is a wrong assert in the class org.springframework.data.auditing.config.AuditingBeanDefinitionRegistrarSupport
Instead of checking for the nullity of both of the parameters, the same parameter (annotationMetadata) is asserted twice:

@Override
public void registerBeanDefinitions(AnnotationMetadata annotationMetadata, BeanDefinitionRegistry registry) {

 Assert.notNull(annotationMetadata, "AnnotationMetadata must not be null!");
 Assert.notNull(annotationMetadata, "BeanDefinitionRegistry must not be null!");

Affects: 2.1.3 (Lovelace SR3)

Referenced from: pull request #328

Backported to: 2.1.4 (Lovelace SR4), 2.0.13 (Kay SR13)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core type: enhancement
Projects
None yet
Development

No branches or pull requests

2 participants