Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor CustomAnnotationTransactionAttributeSource to use computeTransactionAttribute template method [DATACMNS-1745] #2126

Closed
spring-projects-issues opened this issue Jun 16, 2020 · 1 comment
Assignees
Labels
in: repository type: task

Comments

@spring-projects-issues
Copy link

@spring-projects-issues spring-projects-issues commented Jun 16, 2020

Mark Paluch opened DATACMNS-1745 and commented

Starting with Spring Framework 4.1.8, AbstractFallbackTransactionAttributeSource exposes computeTransactionAttribute which can be overridden to determine the TransactionAttribute from a given method.

We should clean up our code and override computeTransactionAttribute with our own attribute computation


Issue Links:

  • DATACMNS-1723 Remove custom TransactionAttributeSources in favor of customized TAS subclasses
    ("is duplicated by")

Referenced from: pull request #449

Backported to: 2.3.2 (Neumann SR2)

@spring-projects-issues
Copy link
Author

@spring-projects-issues spring-projects-issues commented Jun 16, 2020

Oliver Drotbohm commented

That's in place

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: repository type: task
Projects
None yet
Development

No branches or pull requests

2 participants