ConcurrencyModificationException in DefaultEntityCallbacks [DATACMNS-1758]

[spring-projects-issues]

MyeongHyeonLee opened DATACMNS-1758 and commented

similar issue: https://jira.spring.io/browse/DATACMNS-1735

 

ConcurrentModificationException occurred.

 

 

Exception:java.util.ConcurrentModificationException: null
  at java.base/java.util.ArrayList$Itr.checkForComodification(ArrayList.java:1042)
  at java.base/java.util.ArrayList$Itr.next(ArrayList.java:996)
  at org.springframework.data.mapping.callback.DefaultEntityCallbacks.callback(DefaultEntityCallbacks.java:83)
  at org.springframework.data.jdbc.core.JdbcAggregateTemplate.triggerBeforeSave(JdbcAggregateTemplate.java:414)
  at org.springframework.data.jdbc.core.JdbcAggregateTemplate.store(JdbcAggregateTemplate.java:335)
  at org.springframework.data.jdbc.core.JdbcAggregateTemplate.update(JdbcAggregateTemplate.java:183)

 

• callbackDiscoverer.getEntityCallbacks result is cached. but, this List<EntityCallback<T>> can be updated.

 

 

for (EntityCallback<T> callback : callbackDiscoverer.getEntityCallbacks(entityType,
      ResolvableType.forClass(callbackType))) {
}

 

I think it is safe to cache the List locally before executing the loop.

 

 

---

Affects: 2.3.1 (Neumann SR1)

Issue Links:

• DATACMNS-1698 Reduce allocations in EntityCallbackDiscoverer

Referenced from: pull request #453

Backported to: 2.3.2 (Neumann SR2)

[spring-projects-issues]

Mark Paluch commented

We decided to revert the optimization introduced with DATACMNS-1698