Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose ReactiveWrapperConverters.doOnSuccess and doOnError callback hooks [DATACMNS-1763] #2179

Closed
spring-projects-issues opened this issue Jul 6, 2020 · 1 comment
Assignees
Labels
in: repository type: enhancement

Comments

@spring-projects-issues
Copy link

@spring-projects-issues spring-projects-issues commented Jul 6, 2020

Mark Paluch opened DATACMNS-1763 and commented

We should expose callback hooks to attach error and completion consumers to reactive wrappers without the need to add adapters through Publisher types.
Adding callback hooks is useful when augmenting reactive types with callbacks for e.g. metrics collection


No further details from DATACMNS-1763

@spring-projects-issues
Copy link
Author

@spring-projects-issues spring-projects-issues commented Aug 11, 2020

Mark Paluch commented

This change was reverted as we decided to roll it back since the approach for reactive metrics was simplified so these hooks are no longer required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: repository type: enhancement
Projects
None yet
Development

No branches or pull requests

2 participants